Skip to content

Conversation

@tpoisseau
Copy link
Contributor

  • extend @zakodium/tsconfig
  • ci: update typedoc workflow

Closes: #24
Refs: https://github.com/cheminfo/generator-cheminfo/blob/main/ts-migration.md#configure-eslint

@tpoisseau tpoisseau linked an issue Jun 16, 2025 that may be closed by this pull request
@tpoisseau tpoisseau requested a review from targos June 16, 2025 08:59
@codecov
Copy link

codecov bot commented Jun 16, 2025

Codecov Report

Attention: Patch coverage is 87.23404% with 6 lines in your changes missing coverage. Please review.

Project coverage is 94.52%. Comparing base (fd108ca) to head (5bf84c5).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
src/matrixFilters/matrixFilters.ts 0.00% 2 Missing and 1 partial ⚠️
src/matrixFilters/centerZMean.ts 50.00% 1 Missing ⚠️
src/matrixFilters/pqn.ts 50.00% 1 Missing ⚠️
src/matrixFilters/zRescale.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #25      +/-   ##
==========================================
- Coverage   99.38%   94.52%   -4.87%     
==========================================
  Files          29       35       +6     
  Lines         163      365     +202     
  Branches       19       49      +30     
==========================================
+ Hits          162      345     +183     
- Misses          1       19      +18     
- Partials        0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tpoisseau tpoisseau requested a review from targos June 16, 2025 09:06
@targos
Copy link
Member

targos commented Jun 16, 2025

Changes LGTM but there are two failing jobs

@tpoisseau
Copy link
Contributor Author

It should be OK now.
little lint issue and I added allowImportingTsExtensions flag, maybe we should add it to @zakodium/tsconfig

@targos
Copy link
Member

targos commented Jun 16, 2025

Ok, you can open a PR but that's weird. This option is supposed to be true by default when we set rewriteRelativeImportExtensions: https://www.typescriptlang.org/tsconfig/#allowImportingTsExtensions

@tpoisseau
Copy link
Contributor Author

in lib after npm run prepack

export * from "./filterXY.js";
export * from "./FilterXYType.js";
export * from "./filterMatrix.js";
export * from "./FilterMatrixType.js";
export * from "./filters/filters.js";

path extension are properly rewrite to .js even with allowImportingTsExtensions.

@targos
Copy link
Member

targos commented Jun 16, 2025

Maybe typescript-json-schema depends on older version of typescript? Is there an update of the package?

@tpoisseau
Copy link
Contributor Author

typescript-json-schema package.json:

    "ts-node": "^10.9.1",
    "typescript": "~5.5.0",

So yes, it depends on older ts version, but there is no new release since 10 months.

@tpoisseau tpoisseau merged commit eca5d21 into main Jun 16, 2025
8 of 10 checks passed
@tpoisseau tpoisseau deleted the 24-update-ml-gsd-and-migrate-to-esm branch June 16, 2025 09:45
tpoisseau added a commit to zakodium/tsconfig that referenced this pull request Jun 16, 2025
It can be useful for some external tools with older typescript version like `typescript-json-schema`

Refs: mljs/signal-processing#25 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update ml-gsd and migrate to ESM

3 participants