-
Notifications
You must be signed in to change notification settings - Fork 1
refactor!: switch to esm-only and update ml-gsd
#25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
==========================================
- Coverage 99.38% 94.52% -4.87%
==========================================
Files 29 35 +6
Lines 163 365 +202
Branches 19 49 +30
==========================================
+ Hits 162 345 +183
- Misses 1 19 +18
- Partials 0 1 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Changes LGTM but there are two failing jobs |
It seems it 's needed at least for `typescript-json-schema` Refs: https://github.com/mljs/signal-processing/actions/runs/15676577857/job/44158196408?pr=25
|
It should be OK now. |
|
Ok, you can open a PR but that's weird. This option is supposed to be |
|
in lib after export * from "./filterXY.js";
export * from "./FilterXYType.js";
export * from "./filterMatrix.js";
export * from "./FilterMatrixType.js";
export * from "./filters/filters.js";path extension are properly rewrite to |
|
Maybe |
|
So yes, it depends on older ts version, but there is no new release since 10 months. |
It can be useful for some external tools with older typescript version like `typescript-json-schema` Refs: mljs/signal-processing#25 (comment)
@zakodium/tsconfigCloses: #24
Refs: https://github.com/cheminfo/generator-cheminfo/blob/main/ts-migration.md#configure-eslint